Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for config in parent directories #61

Open
tmr232 opened this issue Feb 16, 2020 · 1 comment
Open

Look for config in parent directories #61

tmr232 opened this issue Feb 16, 2020 · 1 comment

Comments

@tmr232
Copy link

tmr232 commented Feb 16, 2020

In many testing frameworks, it is common to an entire directory tree of tests. With the current implementation of get_config, we need to have an approvaltests_config.json file in every directory in the hierarchy. This is annoying and error prone.

I think we should make it search all parent directories until it finds a config file. That way, a single file at the top-level of the tests will be sufficient.

@nickdelgrosso
Copy link
Contributor

nickdelgrosso commented Aug 17, 2022

To add to this discussion, a better model may be to simply check for the approvaltests_Config.json file in the working directory where the test runner is run, rather than relative to the location of the test files themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants