Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReporterWithApprovalPower result is ignored when using FileApprover with PackageSettings or annotations #446

Open
zabetak opened this issue Dec 14, 2023 · 0 comments

Comments

@zabetak
Copy link

zabetak commented Dec 14, 2023

When the reporter configuration is controlled via PackageSettings or annotations the FileApprover will always ignore the result of the defined ReporterWithApprovalPower.

In fact, the top-level reporter when using PackageSettings or annotations is always a FirstWorkingReporter:

return FirstWorkingReporter.combine(getFrontLoadedReporter(), returned);

Due to this the instanceof check inside the FileApprover


will always be false when the reporter is configured with settings/annotations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant