TestUtils.displayFile(String Filename) fails on linux

[brianberzins]

ApprovalTests.Java/approvaltests-util/src/main/java/com/spun/util/tests/TestUtils.java

Lines 146 to 167 in c1021bb

	public static void displayFile(String fileName)
	{
	String cmd = "";
	if (File.separatorChar == '\\')
	{
	cmd = "cmd /C start \"Needed Title\" \"%s\" /B";
	}
	else
	{
	cmd = "open %s";
	}
	try
	{
	cmd = String.format(cmd, fileName);
	Runtime.getRuntime().exec(cmd);
	Thread.sleep(2000);
	}
	catch (Exception e)
	{
	throw ObjectUtils.throwAsError(e);
	}
	}

"open" is macOS specific and won't work out of the box on ubuntu installation.

Honestly don't know how deep you feel this is going, but I'm trying to think of reasonable additions to support Ubuntu. Using file separators won't be sufficient to distinguish between macOS and a linux distro, but I also understand that trying to support a bunch of linux distros might not be easy in this case. xdg-open seems like the most appropriate command if you want to support most linux distros.

[LarsEckart]

I sent you an invite for tomorrow, maybe you can join us? We kinda lack a linux machine to develop on. If not, let me know, maybe I can find someone else.

[brianberzins]

I should be able to make it

…

On Sun, Apr 3, 2022, 11:43 AM Lars Eckart ***@***.***> wrote: I sent you an invite for tomorrow, maybe you can join us? We kinda lack a linux machine to develop on. If not, let me know, maybe I can find someone else. — Reply to this email directly, view it on GitHub <#251 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAS2AGFACBNCMECYB7SZJL3VDHDCRANCNFSM5SNH6AMA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[brianberzins]

Confirmed fixed in 15.1.0

Also showed the customized openers work worked with this:

import com.spun.util.tests.TestUtils;

TestUtils.registerOpener(f -> LinuxOpener.executeOnLinux(f, "firefox"));