-
-
Notifications
You must be signed in to change notification settings - Fork 6
Truncate long messages, instead of dropping. #11
Comments
hey @meidlinga TellemetryData is an array data structure that is internally serialized by app insights sdk to JSON. Any thoughts? |
Thanks for the fast response. I understand the problem now. To keep complexity manageable and runtime fast, I would like to propose the following: The number of messages shall be limited with a configurable value. A good default value would be 20. This prevents taking to long in case of a lot of small elements. If you like this approach, I could work on a PR some time soon. |
First of all, thanks for thinking this one through!
To visualize the problem better, please look at following code: TelemetryData::message($message, $properties);
TelemetryData::message('message', ['foo' => 'foo', 'bar' => 'bar', 'message' => 'this is your log entry')]); Under the hood, a limitation of 64kb is set to the combination of Does it make sense? |
Hello,
As mentioned in the readme, here and here, log messages are dropped, if they exceed a certain size limit.
What is the reason behind dropping, instead of truncating them?
thanks and kind regards
The text was updated successfully, but these errors were encountered: