Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mocha as devDependency to lower package size #18

Merged
merged 2 commits into from May 14, 2020
Merged

add mocha as devDependency to lower package size #18

merged 2 commits into from May 14, 2020

Conversation

thechickennagget
Copy link
Contributor

No description provided.

@lwillmeth
Copy link

lwillmeth commented May 13, 2020 •
edited

Moving mocha to devDependencies is a good change, but why install mocha in npm test?

@boutell
Copy link
Member

boutell commented May 13, 2020

Yeah, that is superfluous. Just move it to devDependencies.

@thechickennagget
Copy link
Contributor Author

i like this package but i hate that it uses "mocha" that has another 24 Dependencies
https://www.npmjs.com/package/mocha?activeTab=dependencies

@thechickennagget
Copy link
Contributor Author

Moving mocha to devDependencies is a good change, but why install mocha in npm test?

Alright i removed the npm install in test script

@boutell boutell merged commit 055f7b1 into apostrophecms:master May 14, 2020
@Owlbertz Owlbertz mentioned this pull request Jan 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boutell boutell boutell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thechickennagget @lwillmeth @boutell