Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reload downtime under load #5185

Open
utay opened this issue May 16, 2024 · 1 comment
Open

Hot reload downtime under load #5185

utay opened this issue May 16, 2024 · 1 comment

Comments

@utay
Copy link

utay commented May 16, 2024

Describe the bug

In production a router process serves hundreds of requests per second; when it hot reloads because the supergraph has been refreshed, a few requests get 502s from the load balancer because it got connection refused on the router.

To Reproduce

I've been able to reproduce pretty consistently:

  • Start the router with hot reload enabled
  • Run any load testing tool such as ab -n 1000000 -c 20 http://127.0.0.1:4000/graphql
  • Modify the supergraph to make the router reload
  • 💥 Right around "reload complete", at least one request will fail with connection refused

Expected behavior

I'd expect 0 downtime as per the docs.

Additional context

  • Router 1.45.0
@Geal
Copy link
Contributor

Geal commented May 27, 2024

hi, thank you for the report. This looks like an issue we have seen elsewhere, we'll investigate and get back to you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants