Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support unix_ms_now in rhai engine #5181

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Support unix_ms_now in rhai engine #5181

wants to merge 8 commits into from
+37 −0

Conversation

shaikatzz
Copy link

@shaikatzz shaikatzz commented May 16, 2024 •
edited

Fixes #5182

Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Tests added and passing3
    • Unit Tests
    • Integration Tests
    • Manual Tests

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩

  3. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩

@shaikatzz shaikatzz requested a review from a team as a code owner May 16, 2024 09:11
@apollo-cla
Copy link

@shaikatzz: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@router-perf
Copy link

router-perf bot commented May 16, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xlarge-request - Stress test with 10 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • no-graphos - Basic stress test, no GraphOS.
  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • const - Basic stress test that runs with a constant number of users

garypen
garypen reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@garypen garypen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR and for the excellent presentation. I particularly appreciate the test and the docs additions.

Could you also create a changeset (so you get appropriate credit when this is released) following the procedure in .changesets/README.md ? re-request a review from me when you are ready.

apollo-router/src/plugins/rhai/tests.rs Show resolved Hide resolved
@shaikatzz
Copy link
Author

Thanks for this PR and for the excellent presentation. I particularly appreciate the test and the docs additions.

Could you also create a changeset (so you get appropriate credit when this is released) following the procedure in .changesets/README.md ? re-request a review from me when you are ready.

Done!

IvanGoncharov
IvanGoncharov approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@IvanGoncharov IvanGoncharov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test has some potential to be flacky :(
At the same time, I can't suggest a better way to test it.

@garypen garypen enabled auto-merge (squash) May 24, 2024 09:48
@shaikatzz
Copy link
Author

@IvanGoncharov @garypen do you know why the tests are not passing? what else is required in order to merge that PR?

@garypen
Copy link
Contributor

garypen commented May 29, 2024

@IvanGoncharov @garypen do you know why the tests are not passing? what else is required in order to merge that PR?

possibly because the CLA wasn't signed. I've just kicked it back into life and we'll see what happens after this run.

@garypen garypen requested review from a team as code owners May 31, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garypen garypen garypen approved these changes

@IvanGoncharov IvanGoncharov IvanGoncharov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support unix time in ms in rhai scripts
4 participants
@shaikatzz @apollo-cla @garypen @IvanGoncharov