Ordering of @key directives causing different behaviors and planning failure

[rruizt]

Hello!

Describe the bug

To Reproduce
Steps to reproduce the behavior:

1. Setup 3 subgraphs:

Subgraph 1

extend schema
@link(url: "https://specs.apollo.dev/federation/v2.3",
  import: ["@key", "@shareable", "@override", "@external", "@extends", "@inaccessible", "@requires"])

type Query {
  own: Storage
}

type Storage @key(fields: "id"){
  id: ID!
}

type Product @key(fields: "id") @key(fields: "uid") {
  id: ID!
  uid: ID!
  colour: Boolean @external
  type: String! @requires(fields: "colour")
}

Subgraph 2

extend schema
@link(url: "https://specs.apollo.dev/federation/v2.3", import: ["@key", "@external", "@extends", "@interfaceObject"])

type Storage @key(fields: "id") @extends {
  id: ID! @external
  shelves: [Shelve!]
}

type Shelve @key(fields: "id") {
  id: ID!
  product: Product!
}

type Product @key(fields: "uid", resolvable: false) {
  uid: ID!
}

Subgraph 3

extend schema @link(url: "https://specs.apollo.dev/federation/v2.3", import: ["@key", "@external", "@extends", "@requires", "@inaccessible"])

type Product @key(fields: "uid") @extends {
  uid: ID! @external
  colour: Boolean @inaccessible
}

3. Submit request

{
  own {
    shelves {
      product {
        type
      }
    }
  }
}

4. See error

{
  "data": {},
  "errors": [
    {
      "message": "value retrieval failed: router bridge error: the deno runtime raised an error: `request: couldn't receive response couldn't deserialize payload `16976028778059605818`: `deno: couldn't deserialize response : `Error(\"invalid neither null nor empty object: found Object {\\\"code\\\": String(\\\"QUERY_PLANNING_FAILED\\\"), \\\"exception\\\": Object {\\\"stacktrace\\\": Array [String(\\\"Cannot add selection of field \\\\\\\"Product.id\\\\\\\" to selection set of parent type \\\\\\\"Product\\\\\\\"\\\")]}}\", line: 0, column: 0)``.`",
      "extensions": {
        "code": "INTERNAL_SERVER_ERROR"
      }
    }
  ]
}

Expected behavior
Router comes back with a working plan

Additional context
Composed the supergraph with rover v0.23.0
I tested it with Apollo Router version 1.43.0

I found two workarounds:

1. Add @key(fields: "id") to the Product types in subgraph 2 and 3
2. Move the @key(fields: "uid") in front of the id one on subgraph 1

type Product @key(fields: "uid") @key(fields: "id")  {
....
}

Thank you so much for your work!

[Geal]

hi! I'm transferring this over to the federation repository, where our planner work is happening. We will look into this issue, but it might take some time to get back to you on this