refactor functions used in apollo-server and the router-bridge into apollo-utils

[o0Ignition0o]

During our recent work on the router-bridge we copy/pasted bits of code from apollo-server and refactored a bit as well.

It would be great if we could refactor this and use the same methods into apollo-utils

[trevor-scheer]

@glasser maybe a good argument for making this a separate package, though exported by @apollo/server is effectively the same.

@o0Ignition0o can this not be imported as is right now? (I haven't dug to look more closely yet)

[benweatherman]

Doing some spot-checking, it seems like a lot of the copypasta is exported already (e.g. https://github.com/apollographql/apollo-server/blob/d75c6cf3360a46ebcd944b2113438be8f549ae6f/packages/apollo-server-core/src/plugin/usageReporting/operationDerivedDataCache.ts#L5-L8)

I'm wondering if this question came about because the rooter depending on apollo-server-core isn't a great option? I think currently it's just depending on the query-planner, so bringing in server might be a tougher sell.

[trevor-scheer]

Just spoke with @glasser about this and we actually already have a precedent for this. We recently moved a very similar signature function (operation registry) to its own package in (@apollo/utils.<xyz>)[https://github.com/apollographql/apollo-utils/tree/main/packages/operationRegistrySignature], doing the same for this function and having it live as a single package makes a lot of sense.

[glasser]

yeah i believe the task is roughly:

• do a quick three-way diff between each of the component functions in router, AS, and utils to make sure they're ~identical
• add remove aliases and the top level usage reporting signature function to utils
• update AS and router to use the new package rather than their own copies
• consider whether this is a reasonable time to put usage reporting: switch to stripIgnoredCharacters apollo-server#6001 into play. i think it might be — instead of it being a sorta backwards incompatible thing for two project it'll only be for one

[trevor-scheer]

Closing as complete via:
apollographql/apollo-utils#92
apollographql/federation-rs#120
apollographql/apollo-server#6449
apollographql/apollo-server#6450