New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine `Content-Type` negotiation #229

Open

trevor-scheer opened this issue Jul 10, 2023 · 0 comments

Member

trevor-scheer commented Jul 10, 2023

The parseBody function is only using startsWith and endsWith to figure the content type.

datasource-rest/src/RESTDataSource.ts

Lines 288 to 289 in 5ac9b52

    
           (contentType.startsWith('application/json') || 
        
             contentType.endsWith('+json'))

In most cases (application/json) this is fine. But for users depending on the +json condition, this breaks for cases like this one:

application/ld+json; charset=utf-8

Ref: #228 (reply in thread)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment