Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs around use of encodeURIComponent or other approaches to dynamic paths #20

Open
glasser opened this issue Oct 11, 2022 · 1 comment
Open

Improve docs around use of encodeURIComponent or other approaches to dynamic paths #20

glasser opened this issue Oct 11, 2022 · 1 comment

Comments

@glasser
Copy link
Member

glasser commented Oct 11, 2022

We closed apollographql/apollo-server#4660 to move it to this repository. We should look to see if the change is still applicable.
@glasser glasser mentioned this issue Oct 11, 2022
Closed
@glasser glasser changed the title Evaluate AS PR 4660 Evaluate AS PR 4660 (security enhancements to resolveURL) Nov 4, 2022
@glasser
Copy link
Member Author

glasser commented Nov 8, 2022

The PR is addressing real problems but I don't think its solutions are quite right.

I do think we could perhaps improve the docs to be even more clear about the importance of using encodeURIComponent, or to encourage the use of a package like url-assembler when dynamically constructing paths.

@glasser glasser changed the title Evaluate AS PR 4660 (security enhancements to resolveURL) Improve docs around use of encodeURIComponent or other approaches to dynamic paths Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glasser