Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question related to changes in request parameters #150

Open
JudgeGreg opened this issue Jan 27, 2023 · 2 comments
Open

Question related to changes in request parameters #150

JudgeGreg opened this issue Jan 27, 2023 · 2 comments

Comments

@JudgeGreg
Copy link

JudgeGreg commented Jan 27, 2023

With apollo-datasource-rest it was possible to set a third argument and set fields there which were used internally in willSendRequest in our codebase. Given that @apollo/datasource-rest only supports two arguments, how would you recommend supplying additional data fields that are purely for internal use and that we don’t intend to send to a server but to use at a later point of execution? Would you recommend setting a new field in the second argument?

Example of what we have with apollo-datasource-rest:

this.patch(path, input, {
      someBooleanField: true,
    });

Thank you.

@trevor-scheer
Copy link
Member

@grego-e It sounds like you'd like some kind of context-y object that's also passed to the public fetch method as well as the hooks?

I think that's a reasonable ask, I'd consider a PR that implements that.

@anzai9
Copy link

anzai9 commented Apr 27, 2023

Any update on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants