Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust typing of ApolloServerTestClient to prevent linter error with createTestClient #5220

Closed
wants to merge 1 commit into from
Closed

Adjust typing of ApolloServerTestClient to prevent linter error with createTestClient #5220

wants to merge 1 commit into from

Conversation

lauriharpf
Copy link

@lauriharpf lauriharpf commented May 17, 2021

Adjusts typing for createTestClient in apollo-server-test so that @typescript-eslint/unbound-method linter error is no longer reported by typescript-eslint.

Closes #4724 . Repo https://github.com/lauriharpf/reproduce-create-test-client-linting-issue has an example that reproduces the issue. Some additional background in Stackoverflow: https://stackoverflow.com/questions/62864908/how-to-prevent-typescript-eslint-unbound-method-errors-on-non-class-typescrip

…/unbound-method linter warning by typescript-eslint
@apollo-cla
Copy link

@lauriharpf: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@glasser
Copy link
Member

glasser commented May 18, 2021

As described in #4724 (comment) I think the whole apollo-server-testing package is unnecessary. Rather than changing its typing I'd prefer to just stop pointing people at it as described in #4952.

@glasser glasser closed this May 18, 2021
@lauriharpf lauriharpf deleted the lauriharpf/fix-create-test-client-lint-error branch May 22, 2021 16:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint error for createTestClient
3 participants