Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usage reporting: fix typo in Buffer.byteLength argument #5149

Merged
merged 1 commit into from Apr 30, 2021

Conversation

glasser
Copy link
Member

@glasser glasser commented Apr 30, 2021

Fortunately, it appears that going back at least to Node 8, there's no
difference between passing "utf8", "uft8" (the typo), or no encoding argument,
so there's no bug here. But it's good to remove the typo (and later versions of
@types/node consider this to be an error).

Fortunately, it appears that going back at least to Node 8, there's no
difference between passing "utf8", "uft8" (the typo), or no encoding argument,
so there's no bug here. But it's good to remove the typo (and later versions of
`@types/node` consider this to be an error).
@glasser glasser enabled auto-merge (squash) April 30, 2021 22:58
@glasser glasser merged commit bd44a4c into main Apr 30, 2021
@glasser glasser deleted the glasser/bytelength-typo branch April 30, 2021 22:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant