remove ApolloServer.willStart #5050
Projects
Comments
|
Also consider making |
glasser
moved this from To Organize
to Straightforward breaking changes
in Apollo Server 3
glasser
added a commit
that referenced
this issue
May 8, 2021
AS v2.22 introduced the method `server.start()` which could be awaited immediately after `new ApolloServer()` in order to catch startup errors (for example, errors loading schema from gateway). This method exists only for non-serverless framework integrations. For `apollo-server` its semantics are integrated into `server.listen()` and for serverless frameworks you typically must set up the handler synchronously. In AS2 this method was optional. This PR makes the method required. So instead of the framework integration kicking off a `start` in the background if you don't do it yourself, it just throws an error telling you to call start. Fixes #5050.
glasser
added a commit
that referenced
this issue
May 10, 2021
AS v2.22 introduced the method `server.start()` which could be awaited immediately after `new ApolloServer()` in order to catch startup errors (for example, errors loading schema from gateway). This method exists only for non-serverless framework integrations. For `apollo-server` its semantics are integrated into `server.listen()` and for serverless frameworks you typically must set up the handler synchronously. In AS2 this method was optional. This PR makes the method required. So instead of the framework integration kicking off a `start` in the background if you don't do it yourself, it just throws an error telling you to call start. Fixes #5050.
glasser
added a commit
that referenced
this issue
May 10, 2021
AS v2.22 introduced the method `server.start()` which could be awaited immediately after `new ApolloServer()` in order to catch startup errors (for example, errors loading schema from gateway). This method exists only for non-serverless framework integrations. For `apollo-server` its semantics are integrated into `server.listen()` and for serverless frameworks you typically must set up the handler synchronously. In AS2 this method was optional. This PR makes the method required. So instead of the framework integration kicking off a `start` in the background if you don't do it yourself, it just throws an error telling you to call start. Fixes #5050.
glasser
added a commit
that referenced
this issue
May 10, 2021
AS v2.22 introduced the method `server.start()` which could be awaited immediately after `new ApolloServer()` in order to catch startup errors (for example, errors loading schema from gateway). This method exists only for non-serverless framework integrations. For `apollo-server` its semantics are integrated into `server.listen()` and for serverless frameworks you typically must set up the handler synchronously. In AS2 this method was optional. This PR makes the method required. So instead of the framework integration kicking off a `start` in the background if you don't do it yourself, it just throws an error telling you to call start. Fixes #5050.
|
Fixed on I didn't change |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
#4981 (v2.22) replaces the protected willStart with start and ensureStarting. It leaves the protected method around for use by other integrations but they should switch to either
start(if the goal is to stop and wait until starting is done, throwing any errors) orensureStarting(if the goal is to begin startup in the background; you can rely on graphQLServerOptions to await success). AS3 should remove willStart.The text was updated successfully, but these errors were encountered: