Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Impact of deprecated graphql-extensions #4889

Closed
DrewML opened this issue Feb 2, 2021 · 7 comments
Closed

Performance Impact of deprecated graphql-extensions #4889

DrewML opened this issue Feb 2, 2021 · 7 comments

Comments

@DrewML
Copy link
Contributor

DrewML commented Feb 2, 2021

Profiling our Apollo Server setup, it looks like the deprecated graphql-extensions package is eating up a significant amount of time. Specifically, the whenResultIsFinished hook seems to be dominating.

I'm not seeing any warnings about deprecated extension usage during startup, so I was surprised to see the runtime cost of (graphql-extensions) is substantial.

image

Running tests locally, it seems like I can eliminate this cost entirely by adding a _extensionsEnabled property to my schema before being passed to the ApolloServer constructor, and that seems to bypass all the extension hooks.

If we're using Apollo Studio to capture and view metrics, are there any metrics we'll be missing by disabling extension support? As far as I can tell, all this functionality was migrated to the newer Plugin API a few months ago.

@glasser
Copy link
Member

glasser commented Feb 2, 2021

Are you saying that you actually see a notable performance improvement when you disable the graphql-extensions schema instrumentation with schema._extensionsEnabled?

The newer plugin schema instrumentation code is pretty similar to the older extensions schema instrumentation code, so I'd be a little surprised if the impact of having both of them on is significantly worse than just having the newer instrumentation code on. Is the other whenResultIsFinished from apollo-server-core (that's the plugin one) and does it use a similar amount of time?

I'm not sure exactly how to interpret the screenshot. whenResultIsFinished itself does very little (calls promise.then, Promise.all, etc, or invokes its callback). Does this only show the time literally spent inside this function, or does it include time waiting on promises created in the function? (I assume the former.)

Now that all the first-party extensions have been rewritten as plugins and we've added deprecation warnings for the use of extensions, I think we could avoid calling enableGraphQLExtensions unless there are actually extensions provided. I would review a PR that makes that change. That said, if there's really a serious performance issue in your benchmarks from just the no-op extension instrumentation, you'll still presumably have half of that from the plugins instrumentation...

@DrewML
Copy link
Contributor Author

DrewML commented Feb 3, 2021

Hey @glasser, thanks for the reply.

I'm not sure exactly how to interpret the screenshot. whenResultIsFinished itself does very little (calls promise.then, Promise.all, etc, or invokes its callback). Does this only show the time literally spent inside this function, or does it include time waiting on promises created in the function? (I assume the former.)

Apologies, I should have clarified a bit more. The Self Time for whenResultIsFinished above is the aggregate time that has been spent on that function in this particular stack (just time spent in the body of this function, not its children). In this screenshot, that stack is a single run of resolvers (one at the top, mostly default resolvers below). When resolving all fields in this request, the whenResultIsFinished from graphql-extensions added 31ms of compute time.

In my tests, the whenResultIsFinished from graphql-extensions takes between 1.2-1.5ms each time it's invoked. Because every field in the schema invokes this function via the wrapped field.resolve, the cost of this no-op grows with the number of fields requested.

image

The newer plugin schema instrumentation code is pretty similar to the older extensions schema instrumentation code, so I'd be a little surprised if the impact of having both of them on is significantly worse than just having the newer instrumentation code on.

They both add some overhead. So doing that work 2x is always going to be more expensive than just once.

@glasser
Copy link
Member

glasser commented Feb 3, 2021

OK. So the complaint is less "the cost of instrumentation is so terrible that it makes getting value out of instrumentation not worth it for your app", and more "the cost of instrumentation is bad enough that we really should only do it once rather than twice"? That makes sense. Can you send a PR to make the enableGraphQLExtensions call conditional?

@DrewML
Copy link
Contributor Author

DrewML commented Feb 3, 2021

Hopefully my input came off more as friendly feedback than a complaint 😄 Apologies if it seemed otherwise!

But yeah, it's definitely more of a request to do that kind of work once 👍

PR in #4893

@glasser
Copy link
Member

glasser commented Feb 3, 2021

Sorry, I meant to say "concern"! This was a helpful issue.

@DrewML
Copy link
Contributor Author

DrewML commented Feb 3, 2021

Thanks for the quick help @glasser!

@glasser
Copy link
Member

glasser commented Feb 9, 2021

Released in v2.20.0.

This was referenced Mar 9, 2021
kodiakhq bot added a commit to ProjectXero/dbds that referenced this issue Mar 17, 2021
Bumps apollo-datasource from 0.7.2 to 0.7.3.

Changelog
Sourced from apollo-datasource's changelog.

CHANGELOG
The version headers in this history reflect the versions of Apollo Server itself.  Versions of other packages (e.g., those which are not actual HTTP integrations; packages not prefixed with "apollo-server", or just supporting packages) may use different versions.
🆕 Please Note!: 🆕 The @apollo/federation and @apollo/gateway packages now live in the apollographql/federation repository.

@apollo/gateway
@apollo/federation

vNEXT

The changes noted within this vNEXT section have not been released yet.  New PRs and commits which introduce changes should include an entry in this vNEXT section as part of their development.  With few exceptions, the format of the entry should follow convention (i.e., prefix with package name, use markdown backtick formatting for package names and code, suffix with a link to the change-set à la [PR #YYY](https://link/pull/YYY), etc.).  When a release is being prepared, a new header will be (manually) created below and the appropriate changes within that release will be moved into the new section.


apollo-server-core: The SIGINT and SIGTERM signal handlers installed by default (when not disabled by stopOnTerminationSignals: false) now stay active (preventing process termination) while the server shuts down, instead of letting a second signal terminate the process. The handlers still re-signal the process after this.stop() concludes. Also, if this.stop() throws, the signal handlers will now log and exit 1 instead of throwing an uncaught exception. [Issue #4931](apollographql/apollo-server#4931)
apollo-server-lambda: (UPDATE THIS MESSAGE BEFORE RELEASE; we are not sure if this actually helps nodejs14 compatibility or if it's just a nice refactor.) Support the nodejs14 runtime by changing the handler to be an async handler. (For backwards compatibility, if the handler receives a callback, it still acts like a non-async handler.) [Issue #1989](apollographql/apollo-server#1989) [PR #5004](apollographql/apollo-server#5004)

v2.21.1

apollo-server-lambda: The onHealthCheck option did not previously work. Additionally, health checks (with onHealthCheck or without) didn't work in all Lambda contexts, such as behind Custom Domains; the path check is now more flexible. [Issue #3999](apollographql/apollo-server#3999) [PR #4969](apollographql/apollo-server#4969) [Issue #4891](apollographql/apollo-server#4891) [PR #4892](apollographql/apollo-server#4892)
The debug option to new ApolloServer (which adds stack traces to errors) now affects errors that come from requests executed with server.executeOperation (and its wrapper apollo-server-testing), instead of just errors that come from requests executed over HTTP. [Issue #4107](apollographql/apollo-server#4107) [PR #4948](apollographql/apollo-server#4948)
Bump version of @apollographql/graphql-playground-html to v1.6.27 and @apollographql/graphql-playground-react to v1.7.39 to resolve incorrectly rendered CDN URL when Playground version was false-y.  [PR #4932](apollographql/apollo-server#4932) [PR #4955](apollographql/apollo-server#4955) [Issue #4937](apollographql/apollo-server#4937)

v2.21.0

Apollo Server can now be installed with graphql@15 without causing peer dependency errors or warnings. (Apollo Server has a file upload feature which was implemented as a wrapper around the graphql-upload package. We have been unable to upgrade our dependency on that package due to backwards-incompatible changes in later versions, and the version we were stuck on did not allow graphql@15 as a peer dependency. We have now switched to a fork of that old version called @apollographql/graphql-upload-8-fork that allows graphql@15.) Also bump the graphql-tools dependency from 4.0.0 to 4.0.8 for graphql@15 support. [Issue #4865](apollographql/apollo-server#4865)

v2.20.0

apollo-server: Previously, ApolloServer.stop() functioned like net.Server.close() in that it did not close idle connections or close active connections after a grace period. This meant that trying to await ApolloServer.stop() could hang indefinitely if there are open connections. Now, this method closes idle connections, and closes active connections after 10 seconds. The grace period can be adjusted by passing the new stopGracePeriodMillis option to new ApolloServer, or disabled by passing Infinity (though it will still close idle connections). Note that this only applies to the "batteries-included" ApolloServer in the apollo-server package with its own built-in Express and HTTP servers. [PR #4908](apollographql/apollo-server#4908) [Issue #4097](apollographql/apollo-server#4097)
apollo-server-core: When used with ApolloGateway, ApolloServer.stop now invokes ApolloGateway.stop. (This makes sense because ApolloServer already invokes ApolloGateway.load which is what starts the behavior stopped by ApolloGateway.stop.) Note that @apollo/gateway 0.23 will expect to be stopped in order for natural program shutdown to occur. [PR #4907](apollographql/apollo-server#4907) [Issue #4428](apollographql/apollo-server#4428)
apollo-server-core: Avoid instrumenting schemas for the old graphql-extensions library unless extensions are provided. [PR #4893](apollographql/apollo-server#4893) [Issue #4889](apollographql/apollo-server#4889)
apollo-server-plugin-response-cache@0.6.0: The shouldReadFromCache and shouldWriteToCache hooks were always documented as returning ValueOrPromise<boolean> (ie, that they could be either sync or async), but they actually only worked if they returned a bool. Now they can be either sync or async as intended. [PR #4890](apollographql/apollo-server#4890) [Issue #4886](apollographql/apollo-server#4886)
apollo-datasource-rest@0.10.0: The RESTDataSource.trace method is now protected instead of private to allow more control over logging and metrics. [PR #3940](apollographql/apollo-server#3940)

v2.19.2

apollo-server-express: types: Export ExpressContext from main module. [PR #4821](apollographql/apollo-server#4821) [Issue #3699](apollographql/apollo-server#3699)
apollo-server-env: types: The first parameter to fetch is now marked as required, as intended and in accordance with the Fetch API specification. [PR #4822](apollographql/apollo-server#4822) [Issue #4741](apollographql/apollo-server#4741)
apollo-server-core: Update graphql-tag package to latest, now with its graphql-js peerDependencies expanded to include ^15.0.0 [PR #4833](apollographql/apollo-server#4833)

v2.19.1

apollo-server-core: The debugPrintReports option to ApolloServerPluginUsageReporting now prints traces as well. [PR #4805](apollographql/apollo-server#4805)

v2.19.0

apollo-server-testing: types: Allow generic variables usage of query and mutate functions. [PR #4383](apollograpqh/apollo-server#4383)
apollo-server-express: Export the GetMiddlewareOptions type. [PR #4599](apollograpqh/apollo-server#4599)
apollo-server-lambda: Fix file uploads - ignore base64 decoding for multipart queries. [PR #4506](apollographql/apollo-server#4506)
apollo-server-core: Do not send  operation documents that cannot be executed to Apollo Studio. Instead, information about these operations will be combined into one "operation" for parse failures, one for validation failures, and one for unknown operation names.



... (truncated)


Commits

c212627 Release
See full diff in compare view




Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants