Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting protobuf: conflict with other libraries (ERROR.prototype.toJSON) #4160

Closed
mizoRC opened this issue May 25, 2020 · 1 comment
Closed

Comments

@mizoRC
Copy link

mizoRC commented May 25, 2020

image

ERROR.prototype.toJSON has conflict with axios library. Please don't override ERROR functions.

image

@abernix
Copy link
Member

abernix commented May 27, 2020

That Error that you've identified is not the global Error object, it is a locally scoped Error function declared within Trace.Error:

https://www.runpkg.com/?apollo-engine-reporting-protobuf@0.5.0/dist/protobuf.js#1197

I agree with your premise that we shouldn't override the global Error.prototype.toJSON, but the last time there was an interoperability claim between Apollo and Axios, it didn't reveal that we were doing anything incorrectly: #1433 (comment).

Please open a reproduction that demonstrates the problem you're experiencing, as requested when opening an issue. Thanks!

@abernix abernix closed this as completed May 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants