Skip to content

Remove TS types from subscriptions.md #3494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Conversation

Kosai106
Copy link
Contributor

@Kosai106 Kosai106 commented Nov 9, 2019

Looking through the Fetching data section, this was the only bit that added types. Removing them avoids confusion and adds consistency across the docs.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Looking through the `Fetching docs` section, this was the only bit that added types. Removing them avoids confusion and adds consistency across the docs.
@apollo-cla
Copy link

@Kosai106: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@abernix abernix merged commit 95557f6 into apollographql:master Nov 13, 2019
@Kosai106 Kosai106 deleted the patch-1 branch November 13, 2019 11:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants