Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Example for integration-specific context args. #3455

Merged
merged 3 commits into from Dec 30, 2019

Conversation

duncanchen
Copy link
Contributor

I follow this example on Azure Function and it failed. After a little digging, I found out the req object is passed as "request". There may be some inconsistency in implementation.

I follow this example on Azure Function and it failed. After a little digging, I found out the req object is passed as "request". There may be some inconsistency in implementation.
@apollo-cla
Copy link

@duncanchen: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

…#3506.

This should hopefully make it more clear what information is available on
the argument to `context`, and how it might need to be adjusted for each
specific integration.
@abernix
Copy link
Member

abernix commented Nov 14, 2019

Thank you for opening this, @duncanchen! In reviewing this PR, I was led to explore our existing documentation in search of a place to reference how the value received by context varies based on integration (e.g. Koa, Hapi, Express, Azure, AWS, etc.), only to find that the information did not exist in our documentation.

Therefore, I opened #3506, which I hope adds a lot of clarity to that! Further, I pushed a commit to this PR to hopefully finish it up.

Do you mind taking a (collective) look at the two changes I submitted, and see if you think this would have saved you from the digging you had to do? I hope so!

Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3506 landed, so this is clear to land now as well. Thanks again for opening this originally!

@abernix abernix changed the title Update authentication.md docs: Example for integration-specific context args. Dec 30, 2019
@abernix abernix merged commit 574d81a into apollographql:master Dec 30, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants