Gateway - don't log updates on startup #3421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zionts
reviewed
Oct 17, 2019
trevor-scheer
force-pushed
the
trevor/gateway-logging
branch
from
48d601e
to
91a4e89
Compare
zionts
reviewed
Oct 17, 2019
trevor-scheer
force-pushed
the
trevor/gateway-logging
branch
from
f30a34e
to
eded62a
Compare
* Only log "updating schema" if a previous schema exists * Remove extraneous else block (the same is resolved immediately below)
trevor-scheer
force-pushed
the
trevor/gateway-logging
branch
from
534989b
to
e2f515e
Compare
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
) Only log "updating schema" if a previous schema exists In the case of a new schema (on first load), log the service id, variant, and mode on which the gateway is running. Apollo-Orig-Commit-AS: apollographql/apollo-server@e57036a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gateway currently spits out INFO logs about updating schema on both startup and during schema updates. It really should only log "updating schema" if a previous schema exists.
** Also removes extraneous neighboring else block (the same is resolved immediately below)