-
Notifications
You must be signed in to change notification settings - Fork 2k
Do not remove Query/Mutation/Subscription types when schema is included if schema references those types #3260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not remove Query/Mutation/Subscription types when schema is included if schema references those types #3260
Conversation
Where including a schema descriptor that references the default type names for Query, Mutation or Subscription prevents the intended extensions from appearing in the federated schema
@JoeTravisKiva: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
if this fixes #3100 i would really appreciate it because i can't get my JVM GraphQL Endpoint to work with Apollo-Gateway 😞 |
@trevor-scheer would you have an idea when this pull request could be reviewed, possibly merged if it fixes the original issue? |
This looks great, thank you for the contribution @JoeTravisKiva! I'll merge now and get this released first thing Monday morning 👍 |
Any chance this will still see a release today? |
@trevor-scheer I'd also very much appreciate a release today if at all possible. Appreciate the support on this one. |
@markguinn @telbot apologies for the delay on this, this is released in Release commit: |
…ed if schema references those types (apollographql/apollo-server#3260) Resolve apollographql/apollo-server#3100 where including a schema descriptor that references the default type names for Query, Mutation or Subscription prevents the intended extensions from appearing in the federated schema. Apollo-Orig-Commit-AS: apollographql/apollo-server@6440c2c
Apollo-Orig-Commit-AS: apollographql/apollo-server@cffcc49
Attempting to resolve #3100
Where including a schema descriptor that references the default type names for Query, Mutation or Subscription prevents the intended extensions from appearing in the federated schema