Revert "Update dependencies accept & boom to new namespace (#3089)" #3111
+5
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commits 0de2942, 97b3f68 and 293e28d. While the change in #3089 change was seemingly justified and straightforward (and as #3106 points out, perhaps _too_ straightforward! 😄), it seems that there was more to the change from `accept` to `@hapi/accept` and `boom` to `@hapi/boom` than just a name change. It seems that the packages may have dropped support for Node.js 6. While Node.js 6 is no longer supported by the Node Foundation, for semantic versioning reasons we weren't intending to completely drop support for it until Apollo Server 3.x. Maybe there's a more granular update here that maintains this support, but this update wasn't as simple as it would have seemed to be at face value (i.e. not a straight package rename of an otherwise internal dependency). Happy to consider re-landing a similar thing, but we need to make it more clear in the `CHANGELOG.md` and possibly reserve it for Apollo Server 3.x, but for now, should revert this to make sure we're not shipping a broken integration for Hapi users, as reported in #3106.
This was referenced Aug 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commits 0de2942, 97b3f68 and 293e28d.
While the change in #3089 change was seemingly justified and straightforward
(and as #3106 points out, perhaps too straightforward! 😄), it seems
that there was more to the change from
acceptto@hapi/acceptandboomto
@hapi/boomthan just a name change. It seems that the packages mayhave dropped support for Node.js 6.
While Node.js 6 is no longer supported by the Node Foundation, for
semantic versioning reasons we weren't intending to completely drop support
for it until Apollo Server 3.x.
Maybe there's a more granular update here that maintains this support, but
this update wasn't as simple as it would have seemed to be at face value
(i.e. not a straight package rename of an otherwise internal dependency).
Happy to consider re-landing a similar thing, but we need to make it more
clear in the
CHANGELOG.mdand possibly reserve it for Apollo Server 3.x,but for now, should revert this to make sure we're not shipping a broken
integration for Hapi users, as reported in #3106.