Fix bug preventing gateway rollback #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abernix seems like the tests always hang on the first |
added 8 commits
July 12, 2019 17:44
JacksonKearl
commented
Jul 15, 2019
| @@ -106,14 +106,14 @@ describe('apollo-server-express', () => { | |||
| const apolloFetch = createApolloFetch({ uri }); | |||
| const firstResult = await apolloFetch({ query: '{ id }' }); | |||
|
|
|||
| expect(firstResult.data).toEqual({ id: 'hi' }); | |||
| expect(firstResult.errors).toBeUndefined(); | |||
There was a problem hiding this comment.
When you assert errors to be undefined before you check if data is correct, Jest will actually tell you what the errors are instead of just saying the data is null
abernix
approved these changes
Jul 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.