gateway: proxy downstream service errors #3019
Merged
+26
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evans
requested review from
jbaxleyiii,
abernix and
trevor-scheer
and removed request for
jbaxleyiii and
abernix
jbaxleyiii
approved these changes
Jul 9, 2019
In the gateway, we currently squash all errors from a single service into a single `Error` with a generic message, such as `Error while fetching subquery from service "registry"`. In other words, the gateway globally overwrites errors from the underlying services and the original errors are appended to `Error.extensions.downstreamErrors`. https://github.com/apollographql/apollo-server/blob/9208e14ba1b96aea663f101e1089b40ca17790c2/packages/apollo-gateway/src/executeQueryPlan.ts#L242 This changes to behavior, so that the errors are proxied in their same form rather than nested into a single error. Ultimately the underlying services are better equipped than the gateway to expose/mask their own errors with `formatErrors` and this removes the gateway as the bottleneck of configuration. The original desire with the message mask was to retain service info / context. To accomplish this, we add the `serviceName` to the `Error.extensions` object for each. so users can investigate the results.
evans
force-pushed
the
evans/unmask-gateway-errors
branch
from
78d2eb5 to
d5e5cff
Compare
|
Hmm. I certainly like the overall idea of not burying the real errors. However, this now means that the gateway can (will!) return errors with a |
|
(Perhaps these errors should lack a path and should instead put the path in an extension? Or maybe the behavior should be different for FetchNodes under FlattenNodes than those that are not?) |
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…#3019) * gateway: proxy downstream service errors In the gateway, we currently squash all errors from a single service into a single `Error` with a generic message, such as `Error while fetching subquery from service "registry"`. In other words, the gateway globally overwrites errors from the underlying services and the original errors are appended to `Error.extensions.downstreamErrors`. https://github.com/apollographql/apollo-server/blob/e849670ffe9e66ad05099aa6b9e9daeea055d489/packages/apollo-gateway/src/executeQueryPlan.ts#L242 This changes to behavior, so that the errors are proxied in their same form rather than nested into a single error. Ultimately the underlying services are better equipped than the gateway to expose/mask their own errors with `formatErrors` and this removes the gateway as the bottleneck of configuration. The original desire with the message mask was to retain service info / context. To accomplish this, we add the `serviceName` to the `Error.extensions` object for each. so users can investigate the results. * gateway: update changelog Apollo-Orig-Commit-AS: apollographql/apollo-server@dc2af9c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the gateway, we currently squash all errors from a single service
into a single
Errorwith a generic message, such asError while fetching subquery from service "registry". In other words, the gatewayglobally overwrites errors from the underlying services and the original
errors are appended to
Error.extensions.downstreamErrors.apollo-server/packages/apollo-gateway/src/executeQueryPlan.ts
Line 242 in 9208e14
This changes to behavior, so that the errors are proxied in their same
form rather than nested into a single error. Ultimately the underlying
services are better equipped than the gateway to expose/mask their own
errors with
formatErrorsand this removes the gateway as thebottleneck of configuration. The original desire with the message mask
was to retain service info / context. To accomplish this, we add the
serviceNameto theError.extensionsobject for each. so users caninvestigate the results.