Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light theme buttons design issue (Playground) #2979

Closed
websolutions-hamburg opened this issue Jul 3, 2019 · 5 comments · Fixed by apollographql/graphql-playground#18
Closed

Comments

@websolutions-hamburg
Copy link

Since apollo-server-express version 2.5.1 and @apollographql/graphql-playground-react version 1.7.26 the buttons have a black background and font color for the light theme. This makes the buttons unrecognizable.

image

@websolutions-hamburg websolutions-hamburg changed the title Light theme buttons design issue Light theme buttons design issue (Playground) Jul 3, 2019
@abernix
Copy link
Member

abernix commented Jul 4, 2019

Thanks for reporting this! Since we don't provide this configuration, this appears that it would need to be fixed upstream in https://github.com/prisma/graphql-playground (which Apollo consumes, albeit through a fork that we update regularly). Do you mind opening an issue (and preferably a PR?) with the repository that provides that integration?

@abernix abernix closed this as completed Jul 4, 2019
@websolutions-hamburg
Copy link
Author

I'm not 100% sure, but I think I saw this issue just in the apollo fork. Apollo use:

<script src="//cdn.jsdelivr.net/npm/@apollographql/graphql-playground-react@1.7.26/build/static/js/middleware.js"></script>

with version 1.7.26. Prisma use currently version 1.7.20, if I'm not wrong. And the Prisma version 1.7.20 doesn't have this issue.

With this configuration everything works fine:

playground: {
  cdnUrl: 'https://cdn.jsdelivr.net/npm',
  version: '1.7.20'
}
<script src="https://cdn.jsdelivr.net/npm/graphql-playground-react@1.7.20/build/static/js/middleware.js"></script>

@abernix
Copy link
Member

abernix commented Jul 4, 2019

Ah, so maybe it's already been fixed upstream and we just need to bring it up to date! I'll check.

@abernix
Copy link
Member

abernix commented Jul 4, 2019

This should be fixed by apollographql/graphql-playground#18. I'll publish it into an alpha on the 1.7.0 branch momentarily!

abernix added a commit that referenced this issue Jul 4, 2019
* Update GraphQL Playground to fix tab colors when `theme: "light"`.

Fixes #2979

* Add CHANGELOG.md
@abernix
Copy link
Member

abernix commented Jul 4, 2019

Thanks for reporting this originally. Please try out the latest release, 2.7.0-alpha.6, and report back if this is still a problem!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants