[Federation] Allow specified directives during validation #2823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The keyFieldsMissingExternal validator should permit standard directives just like we do in composition everywhere else.
|
@trevor-scheer can we add a test for this please? |
trevor-scheer
commented
Jun 11, 2019
...ederation/src/composition/validate/preComposition/__tests__/keyFieldsMissingExternal.test.ts
Outdated
Show resolved
Hide resolved
…tion/__tests__/keyFieldsMissingExternal.test.ts
jbaxleyiii
approved these changes
Jun 11, 2019
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…hql/apollo-server#2823) The keyFieldsMissingExternal validator should permit standard directives just like we do in composition everywhere else. Apollo-Orig-Commit-AS: apollographql/apollo-server@4415648
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keyFieldsMissingExternal validator should permit standard
directives just like we do in composition everywhere else. Otherwise,
we'll throw validation errors for using
@deprecated.