pass context to localGraphQLDatasource for testing purposes #2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sztadii
approved these changes
Jun 11, 2019
jbaxleyiii
approved these changes
Jun 11, 2019
|
@lgandecki This is a wonderful addition! Can you add this to the changelog and I'd love to get this shipped! |
|
Thanks @jbaxleyiii ! Changelog updated. ( I hope that was the way I was supposed to do it :) ) |
|
@lgandecki thank you so much for this PR! It'll be out asap in the next release! |
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…ssContextToLocalDataStore pass context to localGraphQLDatasource for testing purposes Apollo-Orig-Commit-AS: apollographql/apollo-server@b4c6642
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great work with the federation/gateway!
I would like the context to be passed to the graphql execution function in the localGraphQLDataSource, the same way it is handled in the remoteGraphQLDataSource, this way I can build integration tests that do keep the required context during execution. Currently it is ignored, even though the process method receives it.
Since the change is so tiny I hope it won't be a difficult decision - is there any reason NOT to pass the context in this particular case?
Thanks!