From 5eabab2c8a24686d4b0d1f08703fbe47dd93a4b5 Mon Sep 17 00:00:00 2001 From: "Sachin D. Shinde" Date: Thu, 24 Jun 2021 21:34:08 -0700 Subject: [PATCH] Remove "starting" state, since it's never distinguished from "invoking serverWillStart" state. --- packages/apollo-server-core/src/ApolloServer.ts | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/packages/apollo-server-core/src/ApolloServer.ts b/packages/apollo-server-core/src/ApolloServer.ts index 2951eb843c3..a4fc1c232ac 100644 --- a/packages/apollo-server-core/src/ApolloServer.ts +++ b/packages/apollo-server-core/src/ApolloServer.ts @@ -81,11 +81,6 @@ export type SchemaDerivedData = { type ServerState = | { phase: 'initialized'; schemaManager: SchemaManager } - | { - phase: 'starting'; - barrier: Resolvable; - schemaManager: SchemaManager; - } | { phase: 'invoking serverWillStart'; barrier: Resolvable; @@ -370,11 +365,6 @@ export class ApolloServerBase { } const schemaManager = this.state.schemaManager; const barrier = resolvable(); - this.state = { - phase: 'starting', - barrier, - schemaManager, - }; let loadedSchema = false; try { await schemaManager.start(); @@ -523,7 +513,6 @@ export class ApolloServerBase { throw new Error( 'You need to call `server.start()` before using your Apollo Server.', ); - case 'starting': case 'invoking serverWillStart': await this.state.barrier; // continue the while loop