Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GraphQLWsProtocol.Factory.webSocketPayloadComposer #4589

Merged
merged 2 commits into from Dec 19, 2022
Merged

Add GraphQLWsProtocol.Factory.webSocketPayloadComposer #4589

merged 2 commits into from Dec 19, 2022

Conversation

martinbonnin
Copy link
Contributor

Closes #4575

@netlify
Copy link

netlify bot commented Dec 16, 2022 •
edited

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 44fe351
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/639c7b821f9e920008cc0c48

martinbonnin
martinbonnin commented Dec 16, 2022
View reviewed changes
...ollo-runtime/src/commonMain/kotlin/com/apollographql/apollo3/network/ws/GraphQLWsProtocol.kt
private val connectionAcknowledgeTimeoutMs: Long = 10_000,
private val frameType: WsFrameType = WsFrameType.Text,
) : WsProtocol.Factory {
class Factory constructor() : WsProtocol.Factory {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm considering renaming WsProtocol.Factory to WsProtocol.Builder at some point since they more or less serve the same purpose

@martinbonnin martinbonnin mentioned this pull request Dec 16, 2022
Closed
BoD
BoD approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin merged commit 3f7e81b into main Dec 19, 2022
@martinbonnin martinbonnin deleted the websocket-composer branch December 19, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

@sav007 sav007 Awaiting requested review from sav007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support extensions in graphql-ws subscribe message not only for Apollo Persistent Query
2 participants
@martinbonnin @BoD