Un-break Gradle configuration cache in multi module cases #4564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration cache. Instead, add a specific input field.
✅ Deploy Preview for apollo-android-docs canceled.
|
martinbonnin
reviewed
Dec 9, 2022
| @@ -213,6 +213,9 @@ abstract class ApolloGenerateSourcesTask : DefaultTask() { | |||
| @get:Input | |||
| abstract val projectName: Property<String> | |||
|
|
|||
| @get:Input | |||
| abstract val projectPath: Property<String> | |||
There was a problem hiding this comment.
Looks like projectName isn't used anymore. Can you remove it?
There was a problem hiding this comment.
It was still used to be passed to Options.moduleName but that was unused too so I removed it :)
martinbonnin
reviewed
Dec 9, 2022
| @@ -377,7 +380,7 @@ abstract class ApolloGenerateSourcesTask : DefaultTask() { | |||
| ApolloMetadata( | |||
| commonMetadata = if (rememberCommonMetadata) commonMetadata else null, | |||
| compilerMetadata = outputCompilerMetadata, | |||
| moduleName = project.path, | |||
| moduleName = projectPath.get(), | |||
martinbonnin
requested changes
Dec 9, 2022
martinbonnin
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change broke the configuration cache by using
projectat execution time which is forbidden. This introduces a field instead.