Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log deprecation warning instead of printing #4561

Merged
merged 3 commits into from Dec 9, 2022
Merged

Log deprecation warning instead of printing #4561

merged 3 commits into from Dec 9, 2022

Conversation

StefanChmielewski
Copy link
Contributor

Fix for #4560

@apollo-cla
Copy link

@StefanChmielewski: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@netlify
Copy link

netlify bot commented Dec 7, 2022 •
edited

👷 Deploy request for apollo-android-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4c39c49

@StefanChmielewski StefanChmielewski mentioned this pull request Dec 7, 2022
Closed
BoD
BoD approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks a lot!

@martinbonnin martinbonnin merged commit ae87b5b into apollographql:main Dec 9, 2022
@martinbonnin
Copy link
Contributor

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

@martinbonnin martinbonnin martinbonnin approved these changes

@sav007 sav007 Awaiting requested review from sav007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@StefanChmielewski @apollo-cla @martinbonnin @BoD