Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape "Companion" in enum value names #4558

Merged
merged 1 commit into from Dec 7, 2022
Merged

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Dec 6, 2022

Related to #4557

@netlify
Copy link

netlify bot commented Dec 6, 2022

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 850b009
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/638f30f857d26b00087cec5f

@martinbonnin
Copy link
Contributor

Should it be reported to KotlinPoet? Same as square/kotlinpoet#1183?

@martinbonnin
Copy link
Contributor

Should it be reported to KotlinPoet? Same as square/kotlinpoet#1183?

Nevermind, the issue only happens because we are also generating Companion, right? So it's not like it's a general thing 👍 .
LGTM!

@BoD BoD merged commit cd94616 into main Dec 7, 2022
@BoD BoD deleted the escape-compoanion-in-enum-values branch December 7, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants