Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for RFC 373 is missing (Interfaces implementing other interfaces) #2848

Closed
desiderantes opened this issue Jan 7, 2021 · 4 comments · Fixed by #2887
Closed

Support for RFC 373 is missing (Interfaces implementing other interfaces) #2848

desiderantes opened this issue Jan 7, 2021 · 4 comments · Fixed by #2887

Comments

@desiderantes
Copy link

desiderantes commented Jan 7, 2021

Summary
This project does not implement RFC 373 (Interfaces implementing Interfaces)

Version
2.4.6

Description
When trying to parse a .graphqls schema with an interface implementing another interface, the parser fails with the error Unsupported token `implements`

@martinbonnin martinbonnin added this to the 3.0.0-alpha milestone Jan 7, 2021
@martinbonnin martinbonnin changed the title Support for RFC 373 is missing Support for RFC 373 is missing (Interfaces implementing other interfaces) Jan 7, 2021
@martinbonnin
Copy link
Contributor

Hi 👋 , I just made a quick test and it looks like this is already working in dev-3.x: #2851

It parses schema and generates models. The code to detect type conditions for fragments seems ok as well.
The GraphQL type hierarchy not being mirrored in the Kotlin type hierarchy, I think that's about everything that is needed?

Is there any chance you could try one of the 3.0.0-SNAPSHOT to make sure it's working as expected? If everything looks good, this should be reasonnably possible to backport to 2.x.

@desiderantes
Copy link
Author

Well, my original project uses the gradle project so I had to create a new one, but yes, it parses correctly @martinbonnin

@martinbonnin
Copy link
Contributor

Thanks for confirming that, I'll backport for the next 2.x release

@martinbonnin
Copy link
Contributor

The fix is now in main so you can test with SNAPSHOT when they come up in ~30min. I'll make a release on monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants