Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we be testing for _FieldSet / FieldSet directly #129

Open
hwillson opened this issue Jul 20, 2022 · 1 comment
Open

Should we be testing for _FieldSet / FieldSet directly #129

hwillson opened this issue Jul 20, 2022 · 1 comment

Comments

@hwillson
Copy link
Member

hwillson commented Jul 20, 2022 •
edited by dariuszkuc

We're not currently checking to see if a _FieldSet (Fed 1) / FieldSet (Fed 2) scalar is available in the implemented products subgraph. Let's confirm:

  • If we should be testing for this
  • That we should test for _FieldSet with Fed 1 and FieldSet with Fed 2
  • Find out why _FieldSet was renamed to FieldSet
@ddebrunner
Copy link
Contributor

https://community.apollographql.com/t/why-was-fieldset-changed-to-fieldset/4035

:-)

@dariuszkuc dariuszkuc removed their assignment Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hwillson @ddebrunner @dariuszkuc