Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more robust to publish errors #2900

Merged
merged 1 commit into from Jan 26, 2021
Merged

Conversation

martinbonnin
Copy link
Contributor

Fixes #2899

The issue was that the first NETWORK_ONLY watcher was cancelled when trying to refetch and threw and exception before the other store listeners had a chance to do anything.

This changes makes it so that the store always tries to notify all listeners. If one or more fail, the first exception will be rethrown.

@martinbonnin martinbonnin merged commit 63bd112 into main Jan 26, 2021
@martinbonnin martinbonnin deleted the be-more-robust-to-publish-errors branch January 26, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CACHE_ONLY query sometimes not emitting cached data
1 participant