Use Okio's base64 implementation #2870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
java.util.Base64 is only available on API 26+ on Android while Okio's implementation works on all API levels. This fixes apollographql#2857
ansman
requested review from
martinbonnin,
sav007 and
tasomaniac
as code owners
sav007
approved these changes
Jan 13, 2021
|
Awesome, okio's base64 even works on iOS! I'll pull that in |
martinbonnin
added a commit
that referenced
this pull request
Jan 20, 2021
* fix binary compatibility (#2812) * fix binary compatibility Follow up from #2809 * update metalava signatures * Ignore Android modules during Gradle sync. (#2811) This improves autocomplete in IntelliJ/Android Studio * Better UP-TO-DATE checks (#2817) * remove the "Build-Timestamp" Manifest property This makes the builds never up-to-date and compiling things over and over again * better up-to-date checks * Fix broken url in docs (#2829) ## Summary Easy navigation and easy reading for others * Fix broken url in docs (#2828) ## Summary Easy navigation and easy reading for others * Fix broken url in docs (#2827) * Fix broken url in docs ## Summary Easy navigation and easy reading for others * Update plugin-configuration.mdx * Adding ApolloAndroidLogger to apollo-android-support. (#2824) * Adding ApolloAndroidLogger. * Adding logger to KotlinSampleApp Http Cache. * Adding note in README.md about apollo-android-support. * Update README.md Co-authored-by: Martin Bonnin <martin@mbonnin.net> * update metalava signatures Co-authored-by: Martin Bonnin <martin@mbonnin.net> * Debugging renovate * Update dependency gatsby to v2.29.3 (#2836) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Update dependency gatsby-theme-apollo-docs to v4.5.12 (#2837) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Update the ROADMAP ❄️❄️ * Update get-started-multiplatform.mdx Multiplatform code is using NSUrlSession, not NSUrlConnection, thanks @dbaroncelli for reporting this! * bump version to 2.5.0 * release 2.5.0 * version is now 2.5.1-SNAPSHOT * update release documentation * build tags * release 2.5.1 * version is now 2.5.2-SNAPSHOT * fix worflow file * release 2.5.2 * version is now 2.5.3-SNAPSHOT * Update gradle-wrapper.properties (#2852) * Allow to store Json custom scalars in cache records (#2859) * Do not sync android modules in the composite project * Fix storing JsonScalars in Records * Use Okio's base64 implementation (#2870) java.util.Base64 is only available on API 26+ on Android while Okio's implementation works on all API levels. This fixes #2857 * Fix callback blocks (#2873) * Fix potential case where the tests would wait forever (#2875) * configure the Kotlin compiler option for multiplatform projects (#2877) * Fix broken url in docs (#2829) ## Summary Easy navigation and easy reading for others * Fix broken url in docs (#2828) ## Summary Easy navigation and easy reading for others * Adding ApolloAndroidLogger to apollo-android-support. (#2824) * Adding ApolloAndroidLogger. * Adding logger to KotlinSampleApp Http Cache. * Adding note in README.md about apollo-android-support. * Update README.md Co-authored-by: Martin Bonnin <martin@mbonnin.net> * update metalava signatures Co-authored-by: Martin Bonnin <martin@mbonnin.net> * Debugging renovate * Update dependency gatsby to v2.29.3 (#2836) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Update dependency gatsby-theme-apollo-docs to v4.5.12 (#2837) Co-authored-by: Renovate Bot <bot@renovateapp.com> * Update the ROADMAP ❄️❄️ * Update get-started-multiplatform.mdx Multiplatform code is using NSUrlSession, not NSUrlConnection, thanks @dbaroncelli for reporting this! * build tags * fix worflow file * Update gradle-wrapper.properties (#2852) * Allow to store Json custom scalars in cache records (#2859) * Do not sync android modules in the composite project * Fix storing JsonScalars in Records * Fix callback blocks (#2873) * Fix potential case where the tests would wait forever (#2875) * configure the Kotlin compiler option for multiplatform projects (#2877) * cherry-pick of e64d34c Use okio's base64 * fix integration tests * fix integration-tests Co-authored-by: SaintMalik <37118134+saintmalik@users.noreply.github.com> Co-authored-by: Adam McNeilly <amcneilly331@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Nicklas Ansman Giertz <nicklas@ansman.se> Co-authored-by: emmano <emmanuel.ortiguela@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java.util.Base64 is only available on API 26+ on Android while
Okio's implementation works on all API levels.
This fixes #2857