Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加 Close() 方法停止轮询 #254

Merged

Conversation

MoonBall
Copy link
Contributor

@MoonBall MoonBall commented Oct 10, 2022

Developers normally write code to dynamicly create clients. Every client will poll to fetch latest configuration. So there will be more and more clients and connections which are unnecessary.

@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2022

感谢您提出Pull Request,我会尽快Review。我会在1-2日内进行查看或者回复,如果遇到节假日可能会处理较慢,敬请谅解。

@MoonBall MoonBall force-pushed the add-close-method-to-stop-polling branch from e37c756 to ea6a0cf Compare October 10, 2022 16:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3220799420

  • 1 of 13 (7.69%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 74.211%

Changes Missing Coverage Covered Lines Changed/Added Lines %
client.go 1 4 25.0%
component/notify/componet_notify.go 0 9 0.0%
Totals Coverage Status
Change from base Build 3148139036: -0.5%
Covered Lines: 1269
Relevant Lines: 1710

💛 - Coveralls

@MoonBall MoonBall force-pushed the add-close-method-to-stop-polling branch from ea6a0cf to 73167ff Compare October 13, 2022 09:22
@qshuai
Copy link

qshuai commented Nov 9, 2022

我觉得非常有必要,当前我们有动态加载namespace的诉求,当有新的namespace添加时,将会新创建一个apollo客户端实例,原有的实例应该被删除

@zouyx zouyx self-assigned this Dec 9, 2022
@zouyx zouyx changed the base branch from master to develop December 9, 2022 01:44
@zouyx
Copy link
Member

zouyx commented Dec 9, 2022

不好意思,最近有点忙。这两天我会检查并处理。

@zouyx zouyx merged commit 6f65a18 into apolloconfig:develop Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants