Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修正自定义parse内容为空 #253

Merged
merged 1 commit into from Dec 11, 2022

Conversation

fengqi
Copy link
Contributor

@fengqi fengqi commented Sep 29, 2022

No description provided.

@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2022

感谢您提出Pull Request,我会尽快Review。我会在1-2日内进行查看或者回复,如果遇到节假日可能会处理较慢,敬请谅解。

@fengqi
Copy link
Contributor Author

fengqi commented Sep 29, 2022

修复这个问题 #204 可能需要测试下1.9之前的版本,现在问题是无法确定哪个版本取消的content字段

@fengqi fengqi marked this pull request as ready for review September 29, 2022 07:24
@stale
Copy link

stale bot commented Nov 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 28, 2022
@fengqi
Copy link
Contributor Author

fengqi commented Nov 29, 2022

都快被自动关闭了😂

@stale stale bot removed the stale label Nov 29, 2022
@nobodyiam
Copy link
Member

@fengqi
Copy link
Contributor Author

fengqi commented Nov 30, 2022

@fengqi

非 properties 格式的 namespace 的内容是以 content 作为 key 的,如

properties 格式的 namespace 是以实际的配置项作为 key 的,如

这个我是知道的,如果自定义parse针对的是整个配置namespace的话,那prop就是有问题的

@nobodyiam
Copy link
Member

@fengqi
非 properties 格式的 namespace 的内容是以 content 作为 key 的,如

properties 格式的 namespace 是以实际的配置项作为 key 的,如

这个我是知道的,如果自定义parse针对的是整个配置namespace的话,那prop就是有问题的

从功能上来看自定义 parse 应该是针对非 properties 格式的 namespace?不过从代码角度看这个修复也 OK。
@zouyx 你觉得呢?

@zouyx zouyx changed the base branch from master to develop December 9, 2022 01:42
@zouyx zouyx self-assigned this Dec 9, 2022
@zouyx
Copy link
Member

zouyx commented Dec 9, 2022

都快被自动关闭了😂

不好意思,最近有点忙,我会这两天检测并处理。

@zouyx
Copy link
Member

zouyx commented Dec 11, 2022

@fengqi
非 properties 格式的 namespace 的内容是以 content 作为 key 的,如

properties 格式的 namespace 是以实际的配置项作为 key 的,如

这个我是知道的,如果自定义parse针对的是整个配置namespace的话,那prop就是有问题的

从功能上来看自定义 parse 应该是针对非 properties 格式的 namespace?不过从代码角度看这个修复也 OK。 @zouyx 你觉得呢?

确实,我原来的想法是按照宋哥所说,但我觉得这样修复也没啥问题。
@fengqi 感谢指正。

@zouyx zouyx changed the base branch from develop to master December 11, 2022 04:11
@zouyx zouyx changed the base branch from master to develop December 11, 2022 04:11
@zouyx zouyx merged commit 734a8a5 into apolloconfig:develop Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants