Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Next.js examples using Apollo Server 3 to use Apollo Server 4 (and this integration) #33

Closed
martinnabhan opened this issue Nov 8, 2022 · 8 comments

Comments

@martinnabhan
Copy link
Collaborator

martinnabhan commented Nov 8, 2022

There are currently three Next.js examples using Apollo Server:

These examples all use Apollo Server 3 with apollo-server-micro. I'm thinking we should update these to use Apollo Server 4 (and this integration), making it easier for new users to use Next.js with the latest version of Apollo Server.

Some of these examples are quite old so I'm not sure how much work it's going to be to upgrade them.

@martinnabhan martinnabhan changed the title Update Next.js examples using Apollo Server 3 to use Apollo Server 4 with this integration Update Next.js examples using Apollo Server 3 to use Apollo Server 4 (and this integration) Nov 8, 2022
@idoob
Copy link

idoob commented Nov 8, 2022

I'd be happy to submit a PR for this once a release is available. I know there has been some confusion historically where users have been using apollo-server-micro only because that's what the examples show. This is actually how I found this repo. I was trying to figure out how to run the apollo server 4 with next 🙂.

@martinnabhan
Copy link
Collaborator Author

That would be great! I just released v1.0.0 yesterday, and as soon as Next.js 13 support gets merged and released (#34) you should be able to update the Next.js examples to use Apollo Server 4 and this integration without any issues.

@martinnabhan
Copy link
Collaborator Author

I've just released #34 so the integration should be compatible with Next.js 13 now!

@idoob
Copy link

idoob commented Nov 10, 2022

Cool. I've started updating the examples. Will link the PR here within the next day or so.

@idoob
Copy link

idoob commented Nov 11, 2022

Submitted a PR here : vercel/next.js#42771 . The PR updates all three examples to use Apollo Server 4, @as-integrations/next, and to use TypeScript.

@ScottAwesome
Copy link

It would also be useful to test this against the new edge-runtime, which is sure to be the future going forward soon enough I think

@martinnabhan
Copy link
Collaborator Author

vercel/next.js#42771 got merged so I'm closing this.
Awesome work @idoob, thank you!

@trevor-scheer
Copy link
Member

Thanks for your work on this @idoob!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants