Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use either rustfmt.toml or .rustfmt.toml but not both #116

Open
szabgab opened this issue May 5, 2024 · 1 comment · May be fixed by #117
Open

Use either rustfmt.toml or .rustfmt.toml but not both #116

szabgab opened this issue May 5, 2024 · 1 comment · May be fixed by #117

Comments

@szabgab
Copy link

szabgab commented May 5, 2024

It seem that in this repository there is both a rustfmt.toml and a .rustfmt.toml file which is confusing as only one will be used. See this report
@tcharding
Copy link
Collaborator

Thanks for the report, that is definitely an oversight!

tcharding added a commit to tcharding/rust-jsonrpc that referenced this issue May 5, 2024
@tcharding
Delete .rustfmt.toml
a78bbd1 
In commit `14429b13` I introduced a new config file for rustfmt but
did not delete the hidden `.rustfmt.toml` so the new file had no effect.

- Delete the old confid `.rustfmt.toml`

- Make `rustfmt.toml` mirror the current one in `rust-bitcoin` with the
  exception of `edition = 2018`

- Run `cargo +nightly fmt`

Fix: apoelstra#116
@tcharding tcharding linked a pull request May 5, 2024 that will close this issue
Draft
tcharding added a commit to tcharding/rust-jsonrpc that referenced this issue May 17, 2024
@tcharding
Delete .rustfmt.toml
beca1c8 
In commit `14429b13` I introduced a new config file for rustfmt but
did not delete the hidden `.rustfmt.toml` so the new file had no effect.

- Delete the old confid `.rustfmt.toml`

- Make `rustfmt.toml` mirror the current one in `rust-bitcoin` with the
  exception of `edition = 2018`

- Run `cargo +nightly fmt`

Fix: apoelstra#116
tcharding added a commit to tcharding/rust-jsonrpc that referenced this issue May 31, 2024
@tcharding
Delete .rustfmt.toml
b8edc2c 
In commit `14429b13` I introduced a new config file for rustfmt but
did not delete the hidden `.rustfmt.toml` so the new file had no effect.

- Delete the old confid `.rustfmt.toml`

- Make `rustfmt.toml` mirror the current one in `rust-bitcoin` with the
  exception of `edition = 2018`

- Run `cargo +nightly fmt`

Fix: apoelstra#116
tcharding added a commit to tcharding/rust-jsonrpc that referenced this issue May 31, 2024
@tcharding
Delete .rustfmt.toml
8d361ca 
In commit `14429b13` I introduced a new config file for rustfmt but
did not delete the hidden `.rustfmt.toml` so the new file had no effect.

- Delete the old confid `.rustfmt.toml`

- Make `rustfmt.toml` mirror the current one in `rust-bitcoin` with the
  exception of `edition = 2018`

- Run `cargo +nightly fmt`

Fix: apoelstra#116
tcharding added a commit to tcharding/rust-jsonrpc that referenced this issue May 31, 2024
@tcharding
Delete .rustfmt.toml
e80bd94 
In commit `14429b13` I introduced a new config file for rustfmt but
did not delete the hidden `.rustfmt.toml` so the new file had no effect.

- Delete the old confid `.rustfmt.toml`

- Make `rustfmt.toml` mirror the current one in `rust-bitcoin` with the
  exception of `edition = 2018`

- Run `cargo +nightly fmt`

Fix: apoelstra#116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete .rustfmt.toml tcharding/rust-jsonrpc
2 participants
@szabgab @tcharding