Specify --private=false will not exclude private APIs

[chw2054]

Describe the bug

Hi,

I follow the document, please see @apiPrivate

The following command will not build the doc for public API:

apidoc --private false

Please update the doc:

Command line usage to include private APIs: --private [true]

Information

• Version of apidoc: 0.26.0
• Operating system: Linux
• Browser: Chrome

[NicolasCARPi]

It is working fine now (in dev branch at least).

[jwerre]

I'm having this issue as well where using --private false is equivalent to --private true. Perhaps you could do a little more type checking here:

apidoc/bin/apidoc

Line 116 in 3d3025e

apiprivate: argv.private,

[NicolasCARPi]

@jwerre care to propose a PR?

[jwerre]

It looks like these may be resolved by upgrading to command v9

tj/commander.js#1652
tj/commander.js#1571

I'll fork, upgrade and test it out.

[jwerre]

I upgraded commander to v9 and unfortunately that didn't solve the issue. I don't think there is a great way to fix this other than create a pull request for commander.js or switch to something like minimist where you have a bit more control.

[jwerre]

I'd be happy to create a pull request if you'd be ok with switching to minimist.

[NicolasCARPi]

I'm surprised that commander.js with its 13 millions users cannot handle bool flags correctly. I would like to stick with commander.js, so if you can look into solving this while keeping the same lib it would be great. I currently don't have the bandwidth to look into it myself.

[jwerre]

if you can look into solving this while keeping the same lib it would be great

ok, I'll see if I can get some clarification on this.

[jwerre]

tj/commander.js#1759

[jwerre]

I got some feedback form the maintainer of commander.js and it seems to make sense.

tj/commander.js#1759 (comment)

Perhaps this isn't an issue worth addressing.