Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp Cucumber steps and upgrade Cucumber #219

Open
honzajavorek opened this issue Jun 25, 2019 · 2 comments
Open

Revamp Cucumber steps and upgrade Cucumber #219

honzajavorek opened this issue Jun 25, 2019 · 2 comments

Comments

@honzajavorek
Copy link
Contributor

Cucumber in this repo is very outdated, which affects also how the Cucumber steps are implemented. The upgrade needs to be done manually (see dependabot attempt here - #217) and with care. When done, the infrastructure should be radically simplified. See e.g. https://github.com/apiaryio/dredd-hooks-template/ for inspiration.

@artem-zakharchenko
Copy link
Contributor

Do we have a TPLTA approval to update cucumber?

I can update the package as a part of #221, as the pull request rewrites most of theall step definitions anyway. I've also spent some time with the latest Cucumber and I'm familiar with the latest step definition syntax. It should be feasible in that pull request's scope.

Please let me know the approval status. Thanks.

@honzajavorek
Copy link
Contributor Author

@artem-zakharchenko cherry-pick this efb16f2, I'll take care of the rest

$ git fetch origin  # should download all remote branches on the background
$ git cherry-pick efb16f2  # pick this commit (from any branch known to git) and append it to my current branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants