Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The latestBlockPercentileGasPrice gas price strategy fails if the chain ID of a transaction is a big number #1892

Open
bbenligiray opened this issue Oct 3, 2023 · 0 comments

Comments

@bbenligiray
Copy link
Member

See https://github.com/api3dao/tasks/issues/85#issuecomment-1742776927

Recently polygon-testnet started including system transactions in its blocks that have big number chain IDs. ethers treats chain IDs as a Number, which causes it to throw while trying to process said transactions. The latestBlockPercentileGasPrice gas price strategy processes individual transactions from past blocks, which means it would also be affected by this.

Two possible solutions:

  • Remove latestBlockPercentileGasPrice altogether
  • Wrap the ethers function to preprocess transactions so that ethers doesn't see this big number chain IDs (the solution used to address https://github.com/api3dao/tasks/issues/85)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant