Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RRPv0-driven Beacon contracts to be alike the v1 repo #1868

Open
bbenligiray opened this issue Aug 28, 2023 · 0 comments
Open

Update RRPv0-driven Beacon contracts to be alike the v1 repo #1868

bbenligiray opened this issue Aug 28, 2023 · 0 comments

Comments

@bbenligiray
Copy link
Member

@api3/airnode-protocol has old, RRPv0-driven Beacon contracts.

Although we want people to use V1 contracts for data feeds, the v0 Beacon contracts are not obsolete. Specifically, if the user has only RRP access to an Airnode (and no gateway access) this is the only way of running a data feed (or at least simulate one). I think we should keep this contract, but update the behavior to imitate the v1 contracts. For example

  • It shouldn't have whitelisting functionality (similar to Api3ServerV1.sol)
  • It shouldn't do templateId+parameters requests, it should do endpointId+parameters full requests instead (or only templateId requests, that will be cheaper but not as convenient as it will require the template to have been created beforehand)
  • Beacon ID derivation should use v1 template ID derivation (endpointId+parameters) and not v0 (airnode-endpointId+parameters) so that the Beacon IDs on Api3ServerV1 are identical to Beacon IDs on RrpBeaconServerV0
  • Maybe a few more minor things...

Alternatively, we can just move RrpBeaconServerV0.sol out of @api3/airnode-protocol and come back to it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant