Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor airnode-examples to use default contract functionality from airnode-node #1838

Open
dcroote opened this issue Jul 22, 2023 · 0 comments
Open

Refactor airnode-examples to use default contract functionality from airnode-node #1838

dcroote opened this issue Jul 22, 2023 · 0 comments
Labels
enhancement New feature or request examples About the airnode-examples package

Comments

@dcroote
Copy link
Contributor

dcroote commented Jul 22, 2023

Functions in airnode-examples like getAirnodeRrpAddress and getExistingAirnodeRrpV0 were written before airnode-node was capable of defaulting to deployed contract addresses (implemented in #1755 and #1814). Consequently, it would be better to leverage this airnode-node functionality rather than have it partially duplicated in airnode-examples. See also this comment and the original comment inspiring this by @bdrhn9.
@dcroote dcroote added enhancement New feature or request examples About the airnode-examples package labels Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request examples About the airnode-examples package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dcroote