Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airnode PRs are failing on the E2E test step #1551

Closed
aTeoke opened this issue Nov 24, 2022 · 4 comments · Fixed by #1553
Closed

Airnode PRs are failing on the E2E test step #1551

aTeoke opened this issue Nov 24, 2022 · 4 comments · Fixed by #1553
Assignees
Labels
bug Something needs to be fixed

Comments

@aTeoke
Copy link

aTeoke commented Nov 24, 2022

A number of airnode PRs are failing on the E2E test step with the same error: Unable to find value at path: 'market_data.current_price.usd'.

related discussion: https://api3workspace.slack.com/archives/C02AYRX8D89/p1669272881427619

@aTeoke aTeoke added the bug Something needs to be fixed label Nov 24, 2022
@dcroote
Copy link
Contributor

dcroote commented Nov 24, 2022

Debugging (in-progress)

  • Is the API responding. Yes.
  • Is this specific to the E2E integration? No: the basic coingecko integration also fails with the same error for failing airnode-client-dev images
  • Does completely rerunning (all steps, which includes building the images) previously successful CI runs cause CI failure? Yes. Example 1 - latest master commit. Example 2 - PR from a month ago.
  • Does this error also occur for client gateway requests and not just client E2E with the local blockchain? Yes.
  • Does this error occur for cloud deployments? No. Gateway and blockchain requests work (deployed airnode-deployer-dev CI passing and CI failing images on AWS).

@Siegrift
Copy link
Contributor

Siegrift commented Nov 25, 2022

The reason is axios/axios#5298 the response in the Airnode when run from a docker container looks like this:

image

Unfortunately, I had to add a log to print out the request response (we don't log this because there can be sensitive information). Not sure if we should not revisit this decision, because the logs are not helpful.

I see there is already a fix PR created so we can upgrade axios after that point... axios/axios#5306 not sure how this passed through CI though.

@martinkolenic
Copy link
Contributor

martinkolenic commented Nov 29, 2022

Hi @Siegrift , I assume this will be tested at the first completed PR, correct? Don't think we can test this from the user's perspective. I'll move this to Done if you give me an A-OK.

@Siegrift
Copy link
Contributor

I assume this will be tested at the first completed PR, correct?

Since #1553 passed the tests we can consider this tested. Feel free to move to DONE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something needs to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants