fix: Set twig.exception_listener as service parent

[paulandrieux]

Q	A
Branch?	2.7
License	MIT

On branch 2.7, the service api_platform.error_listener defines exception_listener as parent. https://github.com/api-platform/core/blob/main/src/Symfony/Bundle/Resources/config/api.xml#L170

Twig v4.4 deletes the definition of exception_listener and replaces it by twig.exception_listener https://github.com/symfony/twig-bundle/blob/4.4/DependencyInjection/Compiler/ExceptionListenerPass.php#L43

So, when using api_platform 2.7 and twig 4.4, the following error occurs at cache clear :

In ResolveChildDefinitionsPass.php line 76:
                                                                                                 
  Service "api_platform.error_listener": Parent definition "exception_listener" does not exist.

This PR checks if twig is enabled, and changes the parent of api_platform.error_listener from exception_listener to twig.exception_listener.

I'm not convinced that this is the best condition, nor this is the right place to do this check, any advice ?

[soyuka]

Not a huge fan of fixing 2.7 for this as we changed this in 3.0. Can't we fix the twig version on lowest instead ?

[paulandrieux]

The nearest lower compliant Twig version would be 4.3, therefore it means that ApiPlatform 2.7 could not run on Symfony 4.4, which is a LTS largely used.
I made a less intrusive fix, only dereferencing the parent exception_listener service that twig is deleting

[paulandrieux]

For record, a workaround can be to redifine the api_platform.error_listener service in project scope :

//config/services.yml
services:
[...]
    api_platform.error_listener:
        class: ApiPlatform\Symfony\EventListener\ErrorListener
        arguments:
            $controller: "@api_platform.action.exception"
            $logger: "@logger"
            $debug: "%kernel.debug%"

[aaa2000]

On a web application with an api, I have a response in the application/problem+json format instead of html format for the web application.

For record, a workaround can be to redifine the api_platform.error_listener service in project scope :

//config/services.yml
services:
[...]
    api_platform.error_listener:
        class: ApiPlatform\Symfony\EventListener\ErrorListener
        arguments:
            $controller: "@api_platform.action.exception"
            $logger: "@logger"
            $debug: "%kernel.debug%"

Maybe another workaround is to use an alias

exception_listener: '@twig.exception_listener'

[soyuka]

can you fix the tests ?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[alexislefebvre]

Dear bot, please wait.

[llupa]

Very interested in this PR! @paulandrieux Could you find it in your heart to fix the tests too? 😄

[paulandrieux]

@soyuka Tests are now fixed

[soyuka]

perfect thanks @paulandrieux !