Support psr/cache 2 and 3 #4117
Merged
+13
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
approved these changes
Mar 8, 2021
dunglas
approved these changes
Mar 8, 2021
|
Thanks @derrabus! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
psr/cacheinterfaces have been updated with type declarations. This change should not make a difference for API platform because it only consumes cache implementations and does not provide its own cache implementations.This PR also contains changes to a couple of test cases related to caching: Prophecy seems to be confused by the fact that the updated
CacheExceptioninterface extendsThrowable. Since the affected mocks can easily be replaced with a simple anonymous class, I did just that.