You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A bunch of HTTP/HTTPS protocol constants that are supposed to be part of the public TS API are declared in ts/apidefs.h.in and defined in records/RecHttp.cc. We do not link plugins against the records library, so these symbols may not be visible to the linker as they should be. This is a bug and it just happens to work in master. That's fragile; the evidence is the OSX build breaking on #10967 because of simple CMake changes that should have been safe.
Simply moving the definitions from records to api is not enough by itself, because RecHttp.h depends on a subset of those symbols, particularly the TS_ALPN_PROTOCOL_INDEX_ ones. I've played around with defining one set of constants in RecHttp.h and making the TS_ALPN_PROTOCOL_INDEX variables references to that first set of constants. This works fine, but declaring those variables as references might break API compatibility, so it might not be a usable solution.
The text was updated successfully, but these errors were encountered:
A bunch of HTTP/HTTPS protocol constants that are supposed to be part of the public TS API are declared in
ts/apidefs.h.in
and defined inrecords/RecHttp.cc
. We do not link plugins against the records library, so these symbols may not be visible to the linker as they should be. This is a bug and it just happens to work inmaster
. That's fragile; the evidence is the OSX build breaking on #10967 because of simple CMake changes that should have been safe.Simply moving the definitions from
records
toapi
is not enough by itself, becauseRecHttp.h
depends on a subset of those symbols, particularly theTS_ALPN_PROTOCOL_INDEX_
ones. I've played around with defining one set of constants inRecHttp.h
and making theTS_ALPN_PROTOCOL_INDEX
variables references to that first set of constants. This works fine, but declaring those variables as references might break API compatibility, so it might not be a usable solution.The text was updated successfully, but these errors were encountered: