Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Varnish stats with VMOD dyncounters #7805

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AbdelrahmanElawady
Copy link
Contributor

Get Varnish stats by using VMOD dyncounters to create custom stats and fetching them from vstats.

Closes: #7782


Which Traffic Control components are affected by this PR?

  • Traffic Monitor
  • CDN in a Box

What is the best way to verify this PR?

  • Run CIAB with Varnish
  • Query some valid endpoints for 2xx like: docker-compose exec enroller curl -L "http://video.demo1.mycdn.ciab.test"
  • Query invalid endpoints for 4xx like: docker-compose exec enroller curl -L "http://video.demo1.mycdn.ciab.test/any"
  • Either query Traffic Monitor endpoint /publish/DsStats?stats=status_4xx,status_2xx to see the counters increasing or navigate to Traffic Portal UI for similar results.

PR submission checklist

@zrhoffman zrhoffman added Traffic Monitor related to Traffic Monitor cdn-in-a-box related to the Docker-based CDN-in-a-Box system cache-config Cache config generation labels Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #7805 (8d22863) into master (a2720ee) will decrease coverage by 2.90%.
Report is 19 commits behind head on master.
The diff coverage is 69.84%.

@@             Coverage Diff              @@
##             master    #7805      +/-   ##
============================================
- Coverage     31.77%   28.87%   -2.90%     
  Complexity       98       98              
============================================
  Files           717      601     -116     
  Lines         82538    77237    -5301     
  Branches        965       90     -875     
============================================
- Hits          26224    22303    -3921     
+ Misses        54155    52843    -1312     
+ Partials       2159     2091      -68     
Flag Coverage Δ
golib_unit 53.54% <0.00%> (-0.02%) ⬇️
grove_unit 12.02% <ø> (ø)
t3c_unit 5.91% <ø> (ø)
traffic_monitor_unit 26.93% <77.19%> (+0.48%) ⬆️
traffic_ops_unit 21.50% <ø> (+0.04%) ⬆️
traffic_portal_v2 ?
traffic_stats_unit 10.78% <ø> (ø)
unit_tests 25.69% <69.84%> (-3.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lib/varnishcfg/vclbuilder.go 7.84% <0.00%> (-0.33%) ⬇️
lib/varnishcfg/stats.go 0.00% <0.00%> (ø)
traffic_monitor/cache/vstats.go 70.11% <77.19%> (+18.50%) ⬆️

... and 120 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zrhoffman zrhoffman added the Varnish related to Varnish label Sep 27, 2023
@ocket8888 ocket8888 added the low impact affects only a small portion of a CDN, and cannot itself break one label Sep 30, 2023
@AbdelrahmanElawady AbdelrahmanElawady added this to Needs Review in Varnish Support via automation Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cache-config Cache config generation cdn-in-a-box related to the Docker-based CDN-in-a-Box system low impact affects only a small portion of a CDN, and cannot itself break one Traffic Monitor related to Traffic Monitor Varnish related to Varnish
Projects
Varnish Support
  
Needs Review
Development

Successfully merging this pull request may close these issues.

Integrate Varnish with Traffic Stats
3 participants